Add support for a non-backtracking version of pattern disjunction#2242
Merged
gramalingam merged 9 commits intomainfrom May 1, 2025
Merged
Add support for a non-backtracking version of pattern disjunction#2242gramalingam merged 9 commits intomainfrom
gramalingam merged 9 commits intomainfrom
Conversation
❌ 4 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
shubhambhokare1
left a comment
There was a problem hiding this comment.
Thanks! This will be super useful in avoiding bloating the patterns with parameters. Just mentioning a couple clarifying questions.
justinchuby
reviewed
Apr 29, 2025
justinchuby
reviewed
Apr 29, 2025
justinchuby
reviewed
Apr 29, 2025
justinchuby
approved these changes
Apr 30, 2025
Collaborator
justinchuby
left a comment
There was a problem hiding this comment.
Could you add an entry to https://github.com/microsoft/onnxscript/blob/main/docs/api/rewriter_pattern.md ? Thanks
shubhambhokare1
approved these changes
Apr 30, 2025
Contributor
shubhambhokare1
left a comment
There was a problem hiding this comment.
Thanks, will create a follow up PR converting some of the patterns in ort-fusion to utilize OrPatterns
shubhambhokare1
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several fusions need to support multiple variants of a pattern (such as the optional presence of an Add or some such op). This PR adds support for a non-backtracking version of pattern disjunction. We can now use an "Or" between variants such as "Add(...)" and "MatMul(...)", for example.
Supporting unrestricted Or patterns is more complicated, since failure of one alternative will require backtracking, which will require unbinding any bindings added during the unsuccessful partial search. (We can consider that later, if it seems useful.)